Re: [libvirt] [libvirt-designer][PATCH 2/6] Create basic documentation
Hi,
On Thu, Sep 20, 2012 at 04:18:47PM +0200, Michal Privoznik wrote:
On 19.09.2012 17:48, Christophe Fergeau wrote:
> On Tue, Sep 18, 2012 at 05:52:25PM +0200, Michal Privoznik wrote:
>> In fact, it's only bare skeleton for gtkdoc
>
> This seems to be missing a call to GTK_DOC_CHECK in configure.ac, and
> potentially DISTCHECK_CONFIGURE_FLAGS = --enable-gtk-doc=yes
> in Makefile.am
GTK_DOC_CHECK is part of LIBVIRT_DESIGNER_GTK_MISC m4 macro
(m4/virt-gtk-misc.m4) and already is in DISTCHECK_CONFIGURE_FLAGS =
--enable-gtk-doc=yes *is* in Makefile.am.
I am considering this as ACK then if there are no other objections.
Ah, I wrongly assumed that there was no gtk-doc stuff in-tree, this was a
wrong assumption ;) ACK from me, with the minor nit that using
docs/reference/ for the API doc seems more typical than having it straight
into doc. But that can be adjusted the day we have more doc to put there,
so not much point in doing that now.
Christophe
Attachments:
- attachment.sig (application/pgp-signature — 198 bytes)