Re: [libvirt] [PATCH v2 0/2] small gluster fixes

On 02/06/2014 11:09 AM, Christophe Fergeau wrote: > > +/* Check if VIR_CONNECT_LIST_STORAGE_POOLS_FILTERS_POOL_TYPE seems to > + * contain all virConnectListAllStoragePoolsFlags elements > + */ > +verify(VIR_CONNECT_LIST_STORAGE_POOLS_LAST < VIR_CONNECT_LIST_STORAGE_POOLS_FILTERS_POOL_TYPE); > + > +/* Check if virConnectListAllStorageFlags has one flag per known storage > + * pool type */ > +verify(1 << (5+VIR_STORAGE_POOL_LAST) == VIR_CONNECT_LIST_STORAGE_POOLS_LAST - 1); Wow, that does look pretty ugly and hard-coded. At this point, I'm not sure that adding it buys us much.