Re: [libvirt] [PATCH] Fix error squashing when refreshing file volumes
On 05/11/2009 10:33 AM, Daniel Veillard wrote:
On Mon, May 11, 2009 at 10:03:24AM -0400, Cole Robinson wrote:
> When refreshing a file based pool, errors hit when determining a
> volume's format were being squashed, reporting OOM instead. The attached
> patch fixes the error reporting here.
Looks fine, though if you start to add function comments it would be
better to have them match the format used in libvirt.c (i.e. one Return
sentence and description of args and functionality.
ACK,
Daniel
Okay, I committed this, with the comment to match existing convention.
Thanks,
Cole