On 02/04/2013 02:49 PM, Martin Kletzander wrote:
Some files have the magic shifted to some offset other than 0, so we have to support that. I also cleaned up some lines to be more readable and added missing magic for iso file format. --- src/util/virstoragefile.c | 55 ++++++++++++++++++++++++++--------------------- 1 file changed, 31 insertions(+), 24 deletions(-)
[VIR_STORAGE_FILE_DMG] = { - NULL, /* XXX QEMU says there's no magic for dmg, but we should check... */ - ".dmg", + /* XXX QEMU says there's no magic for dmg, + * /usr/share/misc/magic says there is double magic both has + * to be true) and has it disabled as well */
This comment now has closing ')' with no open '('. Did you mean something more like: /* XXX QEMU says there's no magic for dmg, * /usr/share/misc/magic lists double magic (both offsets would * have to match) but then disables that check. */ ACK with the comment touched up. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org