Re: [PATCH] Fix regression on default bus for keyboard/mouse from c4bc4d3b #577

On 1/3/24 16:26, Jonathan Wright wrote: > Signed-off-by: Jonathan Wright <jonathan(a)almalinux.org&gt; > --- > src/conf/domain_postparse.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/conf/domain_postparse.c b/src/conf/domain_postparse.c > index e79913b73f..ee27023f3e 100644 > --- a/src/conf/domain_postparse.c > +++ b/src/conf/domain_postparse.c > @@ -657,6 +657,7 @@ virDomainInputDefPostParse(virDomainInputDef *input, > if ((input->type == VIR_DOMAIN_INPUT_TYPE_MOUSE || > input->type == VIR_DOMAIN_INPUT_TYPE_KBD) && > (ARCH_IS_X86(def->os.arch) || def->os.arch == VIR_ARCH_NONE)) { > + input->bus = VIR_DOMAIN_INPUT_BUS_PS2; > } else if (ARCH_IS_S390(def->os.arch) || > input->type == VIR_DOMAIN_INPUT_TYPE_PASSTHROUGH) { > input->bus = VIR_DOMAIN_INPUT_BUS_VIRTIO; I've tweaked the commit message a bit (so that it's easy to understand what the commit is doing just by reading git log) and merged. Reviewed-by: Michal Privoznik <mprivozn(a)redhat.com&gt; Congratulations on your first libvirt contribution and bug analysis. Michal