Re: [libvirt] [PATCH] nwfilter: move standard XML configs out of examples dir
On Fri, Aug 09, 2019 at 04:46:43PM +0100, Daniel P. Berrangé wrote:
The nwfilter XML configs are not merely examples, they are data that
is
actively shipped and used in production by users.
Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com>
---
You also want to squash the following:
diff --git a/tests/virschematest.c b/tests/virschematest.c
index d5a56d3f96..dabbc02163 100644
--- a/tests/virschematest.c
+++ b/tests/virschematest.c
@@ -231,7 +231,7 @@ mymain(void)
"networkxml2xmlout", "networkxml2confdata");
DO_TEST_DIR("networkport.rng", "virnetworkportxml2xmldata");
DO_TEST_DIR("nodedev.rng", "nodedevschemadata");
- DO_TEST_DIR("nwfilter.rng", "nwfilterxml2xmlout",
"../examples/xml/nwfilter");
+ DO_TEST_DIR("nwfilter.rng", "nwfilterxml2xmlout",
"../src/nwfilter");
DO_TEST_DIR("nwfilterbinding.rng",
"virnwfilterbindingxml2xmldata");
DO_TEST_DIR("secret.rng", "secretxml2xmlin");
DO_TEST_DIR("storagepoolcaps.rng", "storagepoolcapsschemadata");
otherwise distcheck fails. With that:
Reviewed-by: Erik Skultety <eskultet(a)redhat.com>