Re: [libvirt] Still in freeze, third rc tarball available
2011/2/15 Osier Yang <jyang(a)redhat.com>:
于 2011年02月15日 11:32, Daniel Veillard 写道:
>
> Thanks everybody for the testing feedback and fixes, in retrospect
> I should really had done this in previous releases ! So the third
> rc tarball is out, it's likely to be the last one before the release
> (within 48 hours):
>
> ftp://libvirt.org/libvirt/libvirt-0.8.8-rc3.tar.gz
>
> give it a try !
>
> thanks,
>
> Daniel
>
# ./daemon/libvirtd
14:11:15.018: 31796: info : libvirt version: 0.8.8, package: ()
>>> PACKAGE_VERSION and PACKAGER are all defined as "" by default,
do we need to do more checking to print just the following?
configure tests --with-packager(-version) for "no" instead of empty
string. I think --with-packager(-version) should either default to
"no"
diff --git a/configure.ac b/configure.ac
index 3cd824a..9caa902 100644
--- a/configure.ac
+++ b/configure.ac
@@ -32,11 +32,11 @@ AC_SUBST([LIBVIRT_VERSION_NUMBER])
AC_ARG_WITH([packager],
[AS_HELP_STRING([--with-packager],
[Extra packager name])],
- [],[])
+ [],[with_packager=no])
AC_ARG_WITH([packager-version],
[AS_HELP_STRING([--with-packager-version],
[Extra packager version])],
- [],[])
+ [],[with_packager_version=no])
if test "x$with_packager" != "xno"
then
AC_DEFINE_UNQUOTED([PACKAGER], ["$with_packager"],
or be tested for empty string
diff --git a/configure.ac b/configure.ac
index 3cd824a..2f371a7 100644
--- a/configure.ac
+++ b/configure.ac
@@ -37,12 +37,12 @@ AC_ARG_WITH([packager-version],
[AS_HELP_STRING([--with-packager-version],
[Extra packager version])],
[],[])
-if test "x$with_packager" != "xno"
+if test "x$with_packager" != "x"
then
AC_DEFINE_UNQUOTED([PACKAGER], ["$with_packager"],
[Extra package name])
fi
-if test "x$with_packager_version" != "xno"
+if test "x$with_packager_version" != "x"
then
AC_DEFINE_UNQUOTED([PACKAGER_VERSION], ["$with_packager_version"],
[Extra package version])
both approaches fix the cosmetic problem.
Matthias