Re: [libvirt] [PATCH v2] Allow building lxc without virt-login-shell

On 24.11.2015 10:44, Cédric Bosdonnat wrote:

Add a configure option to disable virt-login-shell build even if lxc is enabled. --- Diff to V1:

* moved the configure.ac code into m4/virt-login-shell.m4 * allow building virt-login-shell without lxc * Introduce WITH_SETUID_RPC_CLIENT to have it built if either lxc or virt-login-shell is built.

configure.ac | 9 +++++++++ m4/virt-login-shell.m4 | 27 +++++++++++++++++++++++++++ src/Makefile.am | 4 ++-- tools/Makefile.am | 12 ++++++------ 4 files changed, 44 insertions(+), 8 deletions(-) create mode 100644 m4/virt-login-shell.m4

Sorry for such late review. ACK Michal