Re: [libvirt] [PATCH 4/7] Turn virLogSource into a struct instead of an enum

As part of the goal to get away from doing string matching on filenames when deciding whether to emit a log message, turn the virLogSource enum into a struct which contains a log "name". There will eventually be one virLogSource instance statically declared per source file. To minimise churn in this commit though, a single global instance is used. Signed-off-by: Daniel P. Berrange <berrange(a)redhat.com&gt; --- src/libvirt_private.syms | 1 + src/node_device/node_device_udev.c | 2 +- src/qemu/qemu_capabilities.c | 2 +- src/util/viraudit.c | 7 ++++--- src/util/viraudit.h | 10 ++++++---- src/util/virerror.c | 2 +- src/util/virlog.c | 30 ++++++++++++------------------ src/util/virlog.h | 33 ++++++++++++++++----------------- src/util/virprobe.h | 4 ++-- tests/testutils.c | 2 +- 10 files changed, 45 insertions(+), 48 deletions(-)

diff --git a/src/util/virlog.h b/src/util/virlog.h index 6ba2daa..cb27725 100644 --- a/src/util/virlog.h +++ b/src/util/virlog.h

@@ -68,7 +67,7 @@ typedef enum { * * Do nothing but eat parameters. */ -static inline void virLogEatParams(virLogSource unused, ...) +static inline void virLogEatParams(virLog unused, ...)

{ /* Silence gcc */ unused = unused;