Re: [libvirt] [PATCH 01/11] Fix parsing of port attribute in storage XML configuration

On Fri, Nov 12, 2010 at 10:21:16AM -0700, Eric Blake wrote: > On 11/12/2010 09:22 AM, Daniel P. Berrange wrote: >> The XML docs describe a 'port' attribute for the >> storage source <host> element, but the parser never >> handled it. >> >> * docs/schemas/storagepool.rng: Define port attribute >> * src/conf/storage_conf.c: Add missing parsing/formatting >> of host port number >> * src/conf/storage_conf.h: Remove bogus/unused 'protocol' field >> --- >> docs/schemas/storagepool.rng | 5 +++++ > > Missing corresponding docs/formatstorage.html.in change. As per the commit message, this is already documented, but not implemented !

>> diff --git a/docs/schemas/storagepool.rng b/docs/schemas/storagepool.rng >> index 54eb802..8f067f3 100644 >> --- a/docs/schemas/storagepool.rng >> +++ b/docs/schemas/storagepool.rng >> @@ -186,6 +186,11 @@ >> <attribute name='name'> >> <text/> >> </attribute> >> + <optional> >> + <attribute name='port'> >> + <text/> > > Is text really appropriate? I guess it should reference a port number