Re: [PATCH 03/10] scripts: Add 'qemu-qmp-replies-tool' script for testing and modifying data for qemucapabilitiestest

scripts: Add 'qemu-qmp-replies-tool' script for testing and modifying data for qemucapabilitiestest

+ try: + for line in fh: + jsonstr += line + + if line == '\n': + if command is None: + command = json.loads(jsonstr) + else: + conv.append((command, json.loads(jsonstr))) + command = None + + jsonstr = '' + + if command is not None and jsonstr != '': + conv.append((command, json.loads(jsonstr))) + command = None + jsonstr = '' + + except json.decoder.JSONDecodeError as je: + raise qrtException("JSON error:\n'%s'\nwhile processing snippet:\n'%s'" % (je, jsonstr)) from None

+# Process the replies file programmatically here. +# The 'conv' argument contains the whole conversation as a list of +# (command, reply) tuples, where both command and reply are already parsed JSON +# and thus represented by native python types (dict, list, etc ...) +# +# The code below contains a few examples and hints how to use the programatic +# processing. Do not forget to use '--regenerate' flag to uptate the output files. +# +# Beware that this updates the output file which is used as input for any +# subsequent re-run of the tool which can re-apply the modification. +def modify_replies(conv): + return # remove this to enable modifications + version = None # filled with a dictionary with 'major', 'minor', 'micro' keys + + for (cmd, rep) in conv: + if cmd['execute'] == 'query-version': + version = rep['return']['qemu'] + break + + if version is None: + raise Exception("'query-version' not found in the .replies file") + + idx = -1 + # Find an index of an entry + for i in range(len(conv)): + (cmd, rep) = conv[i] + + if cmd['execute'] == 'device-list-properties': + idx = i + + if idx == -1: + raise Exception("entry not found") + + cmd = {'execute': 'device-list-properties', + 'arguments': {'typename': 'example-device'}} + + reply_unsupp = {'error': {'class': 'DeviceNotFound', + 'desc': "Device 'example-device' not found"}} + + reply = json.loads(''' + { + "return": [ + { + "name": "dummy_prop", + "type": "str" + }, + { + "name": "test", + "type": "str" + } + ] + } + ''') + + if version['major'] >= 8 and version['minor'] > 0: + conv.insert(idx, (cmd, reply)) + else: + conv.insert(idx, (cmd, reply_unsupp))

+The default mode is validation which checks the following: + - each command has a reply and both are valid JSON + - numbering of the 'id' field is as expected + - the input file has the expected JSON formatting + +The tool can be also used to programmaticaly modify the '.replies' file by +editting the 'modify_replies' method directly in the source, or for

+args = parser.parse_args() + +if not args.replyfile and not args.repliesdir: + parser.print_help() + exit(1)

+if args.replyfile: + if not process_one(args.replyfile, args): + fail = True +else: + files = Path(args.repliesdir).glob('*.replies') + + for file in files: + if not process_one(str(file), args): + fail = True