Re: [libvirt] [PATCH] qemu: remove unused QEMU_CAPS_ENABLE_KVM
On Fri, Mar 02, 2018 at 05:07:16AM +0300, Klim Kireev wrote:
It needs for the -enable-kvm flag. This qemu flag can be compiled
out,
but we already detect that case with the QEMU_CAPS_KVM check.
So this check is redundant and can be removed
Signed-off-by: Klim Kireev <klim.s.kireev(a)gmail.com>
---
src/qemu/qemu_capabilities.c | 13 +------------
src/qemu/qemu_capabilities.h | 2 +-
src/qemu/qemu_command.c | 14 ++------------
tests/qemucaps2xmldata/all_1.6.0-1.caps | 2 +-
tests/qemucaps2xmldata/nodisksnapshot_1.6.0-1.caps | 2 +-
tests/qemuhelptest.c | 8 +++-----
tests/qemuxml2argvdata/controller-order.args | 1 -
tests/qemuxml2argvdata/cpu-host-kvmclock.args | 1 -
tests/qemuxml2argvdata/cpu-kvmclock.args | 1 -
tests/qemuxml2argvtest.c | 11 +++++------
10 files changed, 14 insertions(+), 41 deletions(-)
diff --git a/tests/qemuxml2argvdata/controller-order.args
b/tests/qemuxml2argvdata/controller-order.args
index 70a8ba9ce..fea56cc05 100644
--- a/tests/qemuxml2argvdata/controller-order.args
+++ b/tests/qemuxml2argvdata/controller-order.args
@@ -8,7 +8,6 @@ QEMU_AUDIO_DRV=spice \
-name fdr \
-S \
-M rhel6.1.0 \
--enable-kvm \
I presume the -enable-kvm option served some purpose and would like to
see some evidence that we can leave it out, rather than silently
breaking libvirt with some QEMUs that worked before.
On the other hand, these QEMUs (and kvm binaries?) are quite old, maybe
it's time to deprecate everything older than 1.3.0, fail loudly and
get rid of lots of legacy code, like most of the text monitor code,
parsing of 'qemu --help' [0] output and lots of old capabilities.
Jan
[0] if Michal won't have any objections
-m 4096 \
-smp 4,sockets=4,cores=1,threads=1 \
-uuid d091ea82-29e6-2e34-3005-f02617b36e87 \
Attachments:
- signature.asc (application/pgp-signature — 833 bytes)