Re: [libvirt] [PATCH] qemu: Change values of disk discard

On 05/16/2013 08:35 PM, Osier Yang wrote: > QEMU might support more values for "-drive discard", so using Bi-state > values (on/off) for it doesn't make sense. > > "on" maps to "unmap", "off" maps to "ignore": > > <...> > @var{discard} is one of "ignore" (or "off") or "unmap" (or "on") and > controls whether @dfn{discard} (also known as @dfn{trim} or @dfn{unmap}) > requests are ignored or passed to the filesystem. Some machine types > may not support discard requests. > </...> > --- > docs/formatdomain.html.in | 4 ++-- > docs/schemas/domaincommon.rng | 4 ++-- > src/conf/domain_conf.c | 4 ++-- > src/conf/domain_conf.h | 4 ++-- > tests/qemuxml2argvdata/qemuxml2argv-disk-drive-discard.args | 4 ++-- > tests/qemuxml2argvdata/qemuxml2argv-disk-drive-discard.xml | 4 ++-- > 6 files changed, 12 insertions(+), 12 deletions(-) ACK, once you fix... > +++ b/docs/formatdomain.html.in > @@ -1745,8 +1745,8 @@ > The optional <code>discard</code> attribute controls whether > to discard (also known as "trim" or "unmap") requests are > ignored or passed to the filesystem. The value can be either > - "on" (allow the discard request to be passed) or "off" (ingore > - the discard request). > + "unmap" (allow the discard request to be passed) or "ignore" > + (gnore the discard request). s/gnore/ignore/