Re: [PATCH v2 1/8] bhyve: add 'driver' to bhyveProcessStart method

On Wed, Feb 12, 2025 at 15:46:39 +0000, Daniel P. Berrangé wrote: > This allows for passinga NULL connection object in cases where > domain autodestroy is not required. > > Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com&gt; > --- > src/bhyve/bhyve_driver.c | 6 +++--- > src/bhyve/bhyve_process.c | 5 ++--- > src/bhyve/bhyve_process.h | 3 ++- > 3 files changed, 7 insertions(+), 7 deletions(-) > > diff --git a/src/bhyve/bhyve_driver.c b/src/bhyve/bhyve_driver.c > index 8f97ac032c..ea5a9be4fb 100644 > --- a/src/bhyve/bhyve_driver.c > +++ b/src/bhyve/bhyve_driver.c > @@ -79,7 +79,7 @@ bhyveAutostartDomain(virDomainObj *vm, void *opaque) > > if (vm->autostart && !virDomainObjIsActive(vm)) { > virResetLastError(); > - ret = virBhyveProcessStart(data->conn, vm, > + ret = virBhyveProcessStart(bhyve_driver, data->conn, vm, This function already gets the driver passed in data->driver so you don't need to access the global variable.

Reviewed-by: Peter Krempa <pkrempa(a)redhat.com&gt;