On Mon, Oct 22, 2007 at 12:53:48PM +0200, Farkas Levente wrote:
Richard W.M. Jones wrote:
Farkas Levente wrote:
Daniel P. Berrange wrote:
As I mentioned above, doing this in the init script is a bad idea because it does not interact well with domain autostart. The libvirt dameon itself will autostart domains when it starts. So you may be saving the guests at shutdown, but at the next boot any which are marked autostart will be started fresh & the subsequent restore for them will fail since they are already running. Doing this all correctly requires doing it in the daemon not the initscript.
yes, but currently it's not implemented:-( but if you don't autostart any guest (which is the current default) my patch at least working until it'll be implemented.
The problem is that if we put in your patch, we add a set of configuration options which we'll have to keep supporting forever, even when the 'proper' solution is done (whatever that might be).
i can argue with that any 0.x version should have to be compatible with any earlier versions.
There is simply no question of including this code in libvirt. It does work in the general case & does not even get us incrementally towards the general case. Including a half-baked solution which we would need to throw out in the future & start from scratch is not sustainable. Dan. -- |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Perl modules: http://search.cpan.org/~danberr/ -=| |=- Projects: http://freshmeat.net/~danielpb/ -=| |=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|