Re: Patch Re: [Libvir] save and restore guest

Richard W.M. Jones wrote: > Farkas Levente wrote: >> Daniel P. Berrange wrote: >>> As I mentioned above, doing this in the init script is a bad idea >>> because >>> it does not interact well with domain autostart. The libvirt dameon >>> itself >>> will autostart domains when it starts. So you may be saving the guests >>> at shutdown, but at the next boot any which are marked autostart will be >>> started fresh & the subsequent restore for them will fail since they are >>> already running. Doing this all correctly requires doing it in the >>> daemon >>> not the initscript. >> >> yes, but currently it's not implemented:-( but if you don't autostart >> any guest (which is the current default) my patch at least working until >> it'll be implemented. > > The problem is that if we put in your patch, we add a set of > configuration options which we'll have to keep supporting forever, even > when the 'proper' solution is done (whatever that might be). i can argue with that any 0.x version should have to be compatible with any earlier versions.