On Wed, Jan 06, 2021 at 11:05:04 +0100, Tim Wiederhake wrote:
This series adds and enables the Snowridge CPU model.
Note that qemu currently uses the same model ID for Icelake-Server [1] and Snowridge [2]. The correct ID for Icelake is 106 [3], a mistake that has been fixed in libvirt already [4], but is still missing in qemu [5].
[1] https://git.qemu.org/?p=3Dqemu.git;a=3Dblob;f=3Dtarget/i386/cpu.c;h=3D354= 59a38bb1ce7180c5c28e6e215489ef35d3bfe;hb=3DHEAD#l3409 [2] https://git.qemu.org/?p=3Dqemu.git;a=3Dblob;f=3Dtarget/i386/cpu.c;h=3D354= 59a38bb1ce7180c5c28e6e215489ef35d3bfe;hb=3DHEAD#l3661 [3] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/a= rch/x86/include/asm/intel-family.h#n80 [4] https://gitlab.com/libvirt/libvirt/-/commit/1278ac6265589cd83cc2e661056c8= 60e98105507 [5] https://lists.nongnu.org/archive/html/qemu-devel/2020-12/msg00599.html
Tim Wiederhake (7): cputestdata: Add test data for Snowridge cpu_map: Add support for fsrm CPU feature cpu_map: Add support for core-capability CPU feature cputestdata: Snowridge: Update with core-capability CPU feature cpu_map: Add support for split-lock-detect CPU feature cputestdata: Snowridge: Update with split-lock-detect feature cpu_map: Define and enable Snowridge model
Since I already made the suggested changes while reviewing the series to check everything is correct and working as expected, I squashed them into your patches and pushed the result. The required changes were fairly minor: removing "-processor" from the test file names and adding a new test case to cputest.c to make use of the new data in patch 1. So really nothing to require a new version of this series. The rest was just making sure the new test results are updated in each commit to make sure cputest passes. Reviewed-by: Jiri Denemark <jdenemar@redhat.com> And pushed, thanks.