17 Mar
2021
17 Mar
'21
7:02 a.m.
On Tue, 2021-03-16 at 18:32 +0100, Erik Skultety wrote:
+import urllib.request as urllibrequest +import urllib.parse as urllibparse
The aliasing doesn't look like it serves a real purpose here, as it only saves a single character... I'd import, and use, urrlib.request and urllib.parse directly.
+ apistr = str(api_version) + project_uri = f"{gitlab_uri}/api/v{apistr}/projects/{namespace_urlenc}"
Can't you use api_version without explicitly casting/converting it to a string here? It seems to work. With these two nits addressed, Reviewed-by: Andrea Bolognani <abologna@redhat.com> -- Andrea Bolognani / Red Hat / Virtualization