Re: [libvirt] [PATCH v2 0/2] Alter qemu live/cold device attach algorithm

On 06/12/2018 10:32 AM, John Ferlan wrote: > v1: https://www.redhat.com/archives/libvir-list/2018-June/msg00465.html > > The first patch is essentially a repeat of the v1 patch, but with > a more correct commit message. During testing if the same address > was supplied for the --config it wasn't checked. > > The second patch rearranges qemuDomainAttachDeviceLiveAndConfig to > perform CONFIG and LIVE actions separately since the generated > @devConf or @devLive could be different depending on whether the > incoming XML has an <address> or not and whether the corresponding > domain parse and post parse algorithms need to generate some sort > of address for the device. > > > John Ferlan (2): > qemu: Check for existing hostdev address for cold attach device > qemu: Use the correct vm def on cold attach > > src/qemu/qemu_driver.c | 58 +++++++++++++++++++++++++------------------------- > 1 file changed, 29 insertions(+), 29 deletions(-) > ping? Can we come to a consensus either way on this? There's 2 that feel fixing the underlying problem is worth it (myself and Laine) and 1 that would not bother fixing the bug (Jano). Tks - John -- libvir-list mailing list libvir-list(a)redhat.com https://www.redhat.com/mailman/listinfo/libvir-list