On Thu, Oct 14, 2021 at 5:53 PM Michal Prívozník <mprivozn@redhat.com> wrote:
On 10/11/21 2:54 AM, Han Han wrote:
On Mon, Oct 11, 2021 at 3:50 AM Peter Krempa <pkrempa@redhat.com <mailto:pkrempa@redhat.com>> wrote:
On Sat, Oct 09, 2021 at 17:37:42 +0800, Han Han wrote: > The qemu capability will be used for the page_per_vq option of
virtio
> devices. > > Signed-off-by: Han Han <hhan@redhat.com <mailto:hhan@redhat.com>> > --- > src/qemu/qemu_capabilities.c | 6 ++++++ > src/qemu/qemu_capabilities.h | 1 + > tests/qemucapabilitiesdata/caps_2.11.0.s390x.xml | 1 + > tests/qemucapabilitiesdata/caps_2.11.0.x86_64.xml | 1 +
NACK,
OK. BTW, where to check the least version of qemu that libvirt supports?
libvirt.git $ grep QEMU_MIN src/qemu/qemu_capabilities.c #define QEMU_MIN_MAJOR 2 #define QEMU_MIN_MINOR 11 #define QEMU_MIN_MICRO 0
So can you please post v3 and fix also the signed-off we've talked about earlier? Thanks.
OK. v3: https://listman.redhat.com/archives/libvir-list/2021-October/msg00666.html
Michal