Re: [libvirt PATCH 15/28] build: add nft to the list of binaries we attempt to locate
On Wed, May 03, 2023 at 04:26:21PM +0100, Daniel P. Berrangé wrote:
On Sun, Apr 30, 2023 at 11:19:30PM -0400, Laine Stump wrote:
> and include it in BuildRequires and Requires of the rpm specfile to
> make sure it's available when doing official distro builds.
This new dep will need libvirt.yml in libvirt-ci.git to be updated
and the dockerfiles then re-generated.
I don't think we need the BuildRequires, or the build time detection,
at all. Just
#define NFT "nft"
in the relevant file and be done with it. We'll locate the binary at
runtime, same as we're doing with most of them already.
The Requires is still needed, of course.
Maybe we also want to turn the iptables dependency into a Recommends?
That way you will be able to uninstall it for a pure nft-based setup.
... at some point. A lot of stuff seems to still depend on iptables
today, at least in Fedora.
--
Andrea Bolognani / Red Hat / Virtualization