Re: [libvirt] [PATCHv3 31/36] qemu: monitor: Add support for backing name specification for block-stream

On 05/30/2014 02:37 AM, Peter Krempa wrote: s/commad/command/ Again, I think the qemu_capability.[ch] change is needed as a separate commit; but you can get away with the same capability for both block-commit and block-pull since both commands are learning the feature in the same qemu series. Not sure if the capability needs to come first, or if you have it later in the series. This patch is okay (although this and 30/36 should probably wait until Jeff's series is actually committed into qemu.git). [side note - I honestly don't know why we tried to cram so much into qemuMonitorJSONBlockJob through the entire stack; it might have been simpler to have one qemu_monitor.h entry point per QMP command, rather than trying to multiplex. But it may not be worth the refactor now] If these were separate functions instead of multiplexed through a mode argument, then you wouldn't need a check like this (since the check will never fail unless we introduce a bug in qemu_driver.c). ACK -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org