On 07/30/2012 08:40 PM, Kyla Zhang wrote:
For default domain build there is no graphic listen type so it will report error. This patch will fix it with adding default type with "address" --- lib/Sys/Virt/TCK/DomainBuilder.pm | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/lib/Sys/Virt/TCK/DomainBuilder.pm b/lib/Sys/Virt/TCK/DomainBuilder.pm index dfd988e..dbfb65f 100644 --- a/lib/Sys/Virt/TCK/DomainBuilder.pm +++ b/lib/Sys/Virt/TCK/DomainBuilder.pm @@ -460,7 +460,8 @@ sub as_xml { $w->emptyTag("autoport", autoport => $graphic->{autoport}); $w->emptyTag("listen", - listen => $graphic->{listen}); + listen => $graphic->{listen}, + $graphic->{listen_type} ? (type => $graphic->{listen_type}) : type => "address"); $w->emptyTag("keymap", keymap => $graphic->{keymap}); $w->endTag("graphics");
<graphics type='vnc' port='5904'> <listen type='address' address='1.2.3.4'/> </graphics> The 'type' attribute to <listen> could be set either 'address' or 'network' if type='address' the address attribute will contain an IP address or hostname. if type='network' the network attribute will contain the name of a nework in libvirt's list of configured networks. The patch aims to add the missing 'type', default to use value 'address'. ACK