Re: [libvirt] [PATCH] qemu: format server interface without a listen address
On Tue, Jan 20, 2015 at 13:50:22 +0100, Ján Tomko wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=1130390
The listen address is not mandatory for <interface type='server'>
but when it's not specified, we've been formatting it as:
-netdev socket,listen=(null):5558,id=hostnet0
which failed with:
Device 'socket' could not be initialized
Omit the address completely and only format the port in the listen
attribute.
Please mention that the schema didn't allow to specify the model to
justify the schema change.
---
docs/schemas/domaincommon.rng | 10 ++++++++++
src/qemu/qemu_command.c | 3 ++-
tests/qemuxml2argvdata/qemuxml2argv-net-vhostuser.args | 4 +++-
tests/qemuxml2argvdata/qemuxml2argv-net-vhostuser.xml | 5 +++++
4 files changed, 20 insertions(+), 2 deletions(-)a
ACK,
Peter
Attachments:
- signature.asc (application/pgp-signature — 819 bytes)