Re: [libvirt] [PATCH 1/2] Revert "network: Check for QOS before blindly using it"

On 11/22/19 5:08 PM, Erik Skultety wrote:

This reverts commit f4db846c32c0a1e99a0f62b340273e48f8a98ed3.

This patch results in the following error when trying to start essentially any VM with default network:

unsupported configuration: QOS must be defined for network 'default'

Coverity didn't see that the bandwidth == NULL it complained about in virNetDevBandwidthPlug was already checked properly in networkCheckBandwidth, thus causing networkPlugBandwidth to return 0 and finish before a call to virNetDevBandwidthPlug would have been even made.

Signed-off-by: Erik Skultety <eskultet@redhat.com> --- src/network/bridge_driver.c | 14 -------------- 1 file changed, 14 deletions(-)

Reviewed-by: Michal Privoznik <mprivozn@redhat.com> Michal