Re: [libvirt] [PATCH v2 2/9] New functions for virBitmap

On 09/06/2012 04:13 AM, Hu Tao wrote: > In many places we store bitmap info in a chunk of data > (pointed to by a char *), and have redundant codes to > set/unset bits. This patch extends virBitmap, and convert > those codes to use virBitmap in subsequent patches. > --- > > struct _virBitmap { > - size_t size; > - unsigned long *map; > + size_t size; /* size in bits */ > + size_t size2; /* size in LONGs */ The name 'size2' isn't very descriptive. Maybe we should rename to s/size/max_bit/ and s/size2/map_len/ for easier reading?