Re: [libvirt] [PATCH] Define DYNLIB_NAME on OpenBSD.
On 09/06/2012 01:39 AM, Daniel Veillard wrote:
On Tue, Sep 04, 2012 at 04:56:13PM +0200, Jasper Lievisse Adriaanse
wrote:
> >From 05dd99030d865127c874d1b489b9c17412bdbb3b Mon Sep 17 00:00:00 2001
> From: Jasper Lievisse Adriaanse <jasper(a)humppa.nl>
> Date: Tue, 4 Sep 2012 16:48:51 +0200
> Subject: [PATCH] Define DYNLIB_NAME on OpenBSD.
> -#if defined(__linux__) || defined(__linux_gnu__) ||
defined(__sun__) || defined(__FreeBSD__)
> +#if defined(__linux__) || defined(__linux_gnu__) || defined(__sun__) ||
defined(__FreeBSD__) || defined(__OpenBSD__)
> # define DYNLIB_NAME "VBoxXPCOMC.so"
> #elif defined(__APPLE__)
> # define DYNLIB_NAME "VBoxXPCOMC.dylib"
This one is a no-brainer, ACK and pushed,
Agreed, although using \ line continuation for keeping within 80 columns
might have been nice. My usual aversion to platform defines rather than
feature-based configure checks doesn't really apply to this patch,
because I don't know how to write a configure check to determine
preferred dnylib naming, short of doing platform-specific checks in the
first place.
--
Eric Blake eblake(a)redhat.com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
Attachments:
- signature.asc (application/pgp-signature — 617 bytes)