On 11/03/2015 04:13 AM, Ján Tomko wrote:
On Wed, Oct 28, 2015 at 07:54:49AM -0400, John Ferlan wrote:
After a successful qemu-img/qcow-create of the backing file, if we fail to stat the file, change it owner/group, or mode, then the cleanup path should delete the file.
Signed-off-by: John Ferlan <jferlan@redhat.com> --- src/storage/storage_backend.c | 6 ++++++ 1 file changed, 6 insertions(+)
diff --git a/src/storage/storage_backend.c b/src/storage/storage_backend.c index 037d6d7..487c914 100644 --- a/src/storage/storage_backend.c +++ b/src/storage/storage_backend.c @@ -678,6 +678,7 @@ virStorageBackendCreateExecCommand(virStoragePoolObjPtr pool, gid_t gid; uid_t uid; mode_t mode; + bool filecreated = false;
This variable was removed in the previous patch, reordering them would remove the need for that.
I just chose to fix a bug first, then continue with applying the sequence of the original series. Personally I would prefer to squash the two together... Is the order all that precludes an ACK? It doesn't really matter to me. John