Re: [libvirt] [REPOST PATCH 2/6] storage: Cleanup failures virStorageBackendCreateExecCommand

On Wed, Oct 28, 2015 at 07:54:49AM -0400, John Ferlan wrote: > After a successful qemu-img/qcow-create of the backing file, if we > fail to stat the file, change it owner/group, or mode, then the > cleanup path should delete the file. > > Signed-off-by: John Ferlan <jferlan(a)redhat.com&gt; > --- > src/storage/storage_backend.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/src/storage/storage_backend.c b/src/storage/storage_backend.c > index 037d6d7..487c914 100644 > --- a/src/storage/storage_backend.c > +++ b/src/storage/storage_backend.c > @@ -678,6 +678,7 @@ virStorageBackendCreateExecCommand(virStoragePoolObjPtr pool, > gid_t gid; > uid_t uid; > mode_t mode; > + bool filecreated = false; This variable was removed in the previous patch, reordering them would remove the need for that.