Re: [libvirt] [PATCH] fix python events

David Lively <dlively(a)virtualiron.com&gt; wrote: > On Sat, 2008-11-22 at 08:21 +0100, Jim Meyering wrote: >> David Lively <dlively(a)virtualiron.com&gt; wrote: >> > On Fri, 2008-11-21 at 17:51 +0100, Jim Meyering wrote: >> > I'm printing the (user-supplied) object names to help in debugging >> > misbehaving python EventImpls (since there's no static type checking to >> > catch these kinds of things). So instead of printing "<NULL>" when we >> > can't alloc the name, I'm printing something a little more helpful (the >> > appropriate "generic" name). >> >> That's better, indeed. >> I prefer your NAME macro, too. >> ACK, modulo syntax: >> > ... > >> Reversed diff? Better to split long lines, >> not to join. > > Ok. Fixed in attached patch. > >> > + <<< >> >> Trailing white space ^^. > > .. along with this one ... and the trailing whitespace on line 1982. > > *This* time I ran syntax-check :-) ;-) Unqualified ACK, then, assuming those are the only changes.