Re: [libvirt] [PATCH] Allow relative path for qemu backing file

>> + if ('/' != *(vol->backingStore.path)) { >> + virAsprintf(&absolutePath, "%s/%s", pool->def->target.path, >> + vol->backingStore.path); >> + >> + } else { >> + virAsprintf(&absolutePath, "%s", vol->backingStore.path); > > strdup is more efficient here, and avoiding malloc in the first place > even more so. > >> + } >> + accessRetCode = access(absolutePath, R_OK); > > This could segfault on OOM. > >> + VIR_FREE(absolutePath); I believe there needs to be a NULL check here or absolute paths and virAsprintf errors will segfault. I can patch if you don't beat me to it.