Re: [libvirt] [tck PATCH] Add script testing network bandwidth functionality

On 2/26/19 1:07 PM, Daniel P. Berrangé wrote: > Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com&gt; > --- > lib/Sys/Virt/TCK/DomainBuilder.pm | 10 ++ > lib/Sys/Virt/TCK/NetworkBuilder.pm | 20 ++++ > scripts/networks/400-guest-bandwidth.t | 147 +++++++++++++++++++++++++ You forgot to add the test file to MANIFEST :-) Other than that, Reviewed-by: Laine Stump <laine(a)laine.org&gt; (the test could be made more thorough by checking that the bandwidth had actually been set (by checking the output of whatever appropriate tc command, and maybe even by doing a netcat from host to guest and making sure it stays below the limit), but this is a lot better than what we were testing before!)