Re: [libvirt] [PATCH v5 07/10] qemu: Introduce qemuDomainGetJobInfoDumpStats
On Fri, Feb 02, 2018 at 17:40:15 -0500, John Ferlan wrote:
Add an API to allow fetching the memory only dump statistics
for a job via the qemuDomainGetJobInfo API.
Signed-off-by: John Ferlan <jferlan(a)redhat.com>
---
src/qemu/qemu_domain.c | 50 ++++++++++++++++++++++++++++++++++++++++++++
src/qemu/qemu_driver.c | 56 ++++++++++++++++++++++++++++++++++++++++++++++++++
2 files changed, 106 insertions(+)
...
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index 5e537dc89..dc03c0290 100644
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu/qemu_driver.c
...
@@ -13241,6 +13292,11 @@
qemuDomainGetJobStatsInternal(virQEMUDriverPtr driver,
break;
case QEMU_DOMAIN_JOB_STATS_TYPE_MEMDUMP:
+ if (qemuDomainGetJobInfoDumpStats(driver, vm, jobInfo) < 0)
+ goto cleanup;
+ ret = 0;
You can remove this "ret = 0" after changing 1/10...
+ break;
+
case QEMU_DOMAIN_JOB_STATS_TYPE_NONE:
break;
}
With the above line removed:
Reviewed-by: Jiri Denemark <jdenemar(a)redhat.com>