Re: [libvirt] [PATCHv2 1/1] Assign spapr-vio address type to ibmvscsi controller

On 05/10/2012 03:37 AM, Daniel P. Berrange wrote: > On Thu, May 10, 2012 at 04:39:48PM +0800, Li Zhang wrote: >> For pseries guest, the default controller model is >> ibmvscsi controller, this controller only can work >> on spapr-vio address. >> >> This patch is to assign spapr-vio address type to >> ibmvscsi controller. >> >> Signed-off-by: Li Zhang<zhlcindy(a)linux.vnet.ibm.com> >> --- >> src/qemu/qemu_command.c | 14 +++++++++++--- >> 1 file changed, 11 insertions(+), 3 deletions(-) >> > > ACK Needs a v2; 'make check' failed. In particular, with: $ make -C tests check TESTS=qemuxml2argvtest VIR_TEST_DEBUG=1 I see failures like: 148) QEMU XML-2-ARGV usb-redir ... Offset 457 Expect [bus=pci.0,addr=0x4.0x1] Actual [reg=0x2000] ... FAILED 149) QEMU XML-2-ARGV usb1-usb2 ... libvir: QEMU error : XML error: spapr-vio address 0x2000 already in use FAILED I don't know if the change in output is expected or a regression, so I'd feel a bit safer if we waited until after 0.9.12 to apply a fixed v2.