On 2/4/21 1:06 PM, Pavel Hrdina wrote:
On Thu, Feb 04, 2021 at 01:00:51PM +0100, Michal Privoznik wrote:
On 2/3/21 7:01 PM, Pavel Hrdina wrote:
The correct backend type is 'vc', same as in qemuBuildChrChardevStr() where we generate qemu command line.
Signed-off-by: Pavel Hrdina <phrdina@redhat.com> --- src/qemu/qemu_monitor_json.c | 5 ++++- tests/qemumonitorjsontest.c | 2 +- 2 files changed, 5 insertions(+), 2 deletions(-)
But maybe we could deduplicate some code? I mean, qemuBuildChrChardevStr() and some parts of qemuMonitorJSONAttachCharDevCommand() look very similar and we could use virQEMUBuildCommandLineJSON() or something. But merging the patch as is is okay too.
That was a plan but it is not that trivial as the JSON and cmdline syntax are different.
Oh, are they? I only quickly skimmed through both functions and it appeared similar. If it isn't then it may be more confusing to merge them together. Michal