Re: [libvirt] [Qemu-devel] [RFC PATCH 2/4] qmp/hmp: Add getfd_file monitor command

On Tue, 22 May 2012 16:02:19 -0400 Corey Bryant<coreyb(a)linux.vnet.ibm.com> wrote: >> But there's a small problem. Today getfd commands are closely tied to the >> Monitor. In Anthony's development tree, the getfd commands are tied to the >> new QMP server's session support. >> >> Asking you to integrate the new QMP server only to have the getfd command >> returning a simple integer would be too much, but at the same time I think >> you'll have to at least to break it from the monitor. This means moving its >> data structure away from the Monitor object and probably reworking the >> internal API used to get fds (ie. monitor_get_fd()). >> >> Shouldn't be hard, but you should be careful not to break external users. >> > > Just to verify, are you talking about moving the "fds" off the Monitor > struct? --> QLIST_HEAD(,mon_fd_t) fds; Yes. > Was this already moved away from the Monitor struct in Anthony's > development tree? If not do you have a recommendation on where to move it? Yes, iirc it moved inside the new QMP server session support in Anthony's tree. > I think this would make more sense to me if I took a look at the getfd > code in Anthony's development tree. Is this the correct tree? I had > some issues cloning it. https://github.com/aliguori/qemu-next.git The 'development' tree I'm referring to is the old glib branch in git://repo.or.cz/qemu/aliguori.git.