On 07/03/2013 10:21 AM, Daniel P. Berrange wrote:
On Wed, Jul 03, 2013 at 04:19:01PM +0200, Michal Privoznik wrote:
> On 03.07.2013 15:59, Daniel P. Berrange wrote:
>> On Wed, Jul 03, 2013 at 07:54:51AM -0600, Eric Blake wrote:
>>> On 07/03/2013 07:46 AM, Daniel P. Berrange wrote:
>>>>> What am I doing wrong with the virsh attach-device command or XML?
>>>>
>>>> There is no support for hotplug of any character device (that
>>>> covers serial, parallel, console, channnel elements in the XML)
>>>
>>> Although that's about to change in libvirt 1.1.1:
>>>
https://www.redhat.com/archives/libvir-list/2013-July/msg00125.html
>>
>> Yes & no. Yes, libvirt will support hotplug, but that's only actually
>> going to work for devices which are PCI based. eg virtio-serial and
>> virtio-console. You can't hotplug <serial> or <paralle> devices
which
>> use the ISA bus, which is what Chris was trying todo here.
>
> But that's just a QEMU limitation. If QEMU learns to hotplug a device
> onto ISA bus, libvirt will allow it.
Did real ISA buses ever support hotplug ? I thought hotplug only came
along when PCI buses arrived. I'm rather doubting anyone is going to do
work for ISA device hotplug in QEMU
Daniel
IIRC they did not, I don't think PCI supported it even until later
revisions. Even when it did, I only saw it on fairly big hardware and
with specific devices. Either way, I'm concerned about the error
message here, not that it doesn't work :D
--
Chris Evich, RHCA, RHCE, RHCDS, RHCSS
Quality Assurance Engineer
e-mail: cevich + `@' +
redhat.com o: 1-888-RED-HAT1 x44214