Re: [libvirt] PATCH: Remove PID file before starting QEMU, and after shutdown
On Mon, Apr 20, 2009 at 08:52:44PM +0200, Daniel Veillard wrote:
On Mon, Apr 20, 2009 at 01:52:30PM +0100, Daniel P. Berrange wrote:
> We spawn QEMU with a -pidfile option to write its PID out to a file. This
> file is never removed though, so next time the guest starts there is small
> race condition where we might be unlucky enough to read the old PID out of
> the file, instead of the new QEMU PID. This patch adds a call to remove
> the pidfile from disk when a guest is shut down. As an extra preventative
> measure, we also delete it before starting a guest
Looks right to me ! ACK
Committed this now
Daniel
--
|: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|