Re: [libvirt] [PATCH v4b] Add functions for handling exponential backoff loops.

Having two "whiles" like that looks kinda off... I'd rather have something like   while (!virTimeBackOffHasExpired(&timeout)) or preferably something better than what I can come up with :)

> +/** > + * virTimeBackOffWhile > + * @var: Timeout variable (with type virTimeBackOffVar *). > + * > + * You must initialize @var first by calling the following function, > + * which also starts the timer: > + * > + * if (virTimeBackOffStart(&var, first, timeout) < 0) { > + *   // handle errors > + * } > + * > + * Then you use a while loop: > + * > + * while (virTimeBackOffWhile(&var)) { > + *   //... > + * } > + * > + * The while loop that runs the body of the code repeatedly, with an > + * exponential backoff.  It first waits for first milliseconds, then > + * runs the body, then waits for 2*first ms, then runs the body again. > + * Then 4*first ms, and so on. > + * > + * When timeout milliseconds is reached, the while loop ends. > + * > + * The body should use "break" or "goto" when whatever condition it is > + * testing for succeeds (or there is an unrecoverable error). > + */ > +bool virTimeBackOffWhile(virTimeBackOffVar *var); > + >  #endif API documentation should live in the .c file, like you did with virTimeBackOffStart(). I guess it's just a consequence of the "a" implementation using a macro for this part :)