Re: [libvirt] [PATCH 07/10] nodeinfo: Phase out cpu_set_t usage
On Mon, 2015-07-20 at 15:41 +0200, Peter Krempa wrote:
> + /* Biggest value we can expect to be used as either socket id
> + * or core id. Bitmaps will need to be sized accordingly */
> + const int ID_MAX = 4095;
I think this should be a more global setting. We have quite a few
places
where we invent arbitrary maximum cpu counts. One of them is
virProcessSetAffinity.
Definitely agreed. We should define such limits in a single
place and stick to them.
Otherwise looks good to me, but I'd really want to avoid
multiple
definitions of the same maximum variable.
I've left the code unchanged in v2 because this looks like
a task that would require quite a bit of research, and I'd
prefer if that didn't block an otherwise ACKed series which
in turn is a requirement of another series I've posted.
So I'm going to look into it and remove duplicate
definitions in a follow-up patch, if you're okay with that.
Cheers.
--
Andrea Bolognani
Software Engineer - Virtualization Team