On Tuesday 28 October 2014 11:15:20 Eric Blake wrote:
On 10/28/2014 10:58 AM, Dmitry Guryanov wrote:
Since libvirt.h has been splitted out, generator.py
s/splitted/split/
should be fixed accordingly. So add full list of header files.
Does this still work when targetting older libvirt prior to the header split? If so, then ACK.
Yes, it works, because "libvirt" is in the list.
+libvirt_headers = ["libvirt", + "libvirt-domain", + "libvirt-domain-snapshot", + "libvirt-event", + "libvirt-host", + "libvirt-interface", + "libvirt-network", + "libvirt-nodedev", + "libvirt-nwfilter", + "libvirt-secret", + "libvirt-storage", + "libvirt-stream",]
Might be worth putting the ] on its own line; then, if we add new files in the future, it will be a one line addition instead of having to modify an existing line.
OK, I'll resend the patch. -- Dmitry Guryanov