On 1/15/26 15:09, Daniel P. Berrangé wrote:
On Thu, Jan 15, 2026 at 03:03:29PM +0100, Michal Privoznik via Devel wrote:
From: Michal Privoznik <mprivozn@redhat.com>
Some functions inside of domain_logcontext call virLogManager APIs. But that one is available only when remote driver is enabled (from src/logging/meson.build):
if conf.has('WITH_REMOTE') log_driver_lib = static_library( 'virt_log_driver', [ log_driver_sources, log_protocol_generated, ], ...
Guard calls to virLogManager APIs with #ifdef WITH_REMOTE.
Should we #ifdef the entire file ? It seems like its functionality is only going to be applicable to server side drivers.
Fair enough. The old log handler is still available, but no driver that cares is compiled when remote driver is disabled. V2 on its way. Michal