Re: [libvirt] [RFC PATCH v2 2/3] qemu: RDMA migration support using 'rdma' URI

On Mon, Jan 13, 2014 at 14:28:11 +0800, mrhines(a)linux.vnet.ibm.com wrote: > From: "Michael R. Hines" <mrhines(a)us.ibm.com&gt; > > The switch from x-rdma => rdma has not yet happened, > but at least we can review the patch until it goes > through on qemu-devel. The paragraph above would better fit after "---" below so that it disappears once this patch gets applied as the statement won't be valid anymore at that time. > USAGE: $ virsh migrate --live --migrateuri x-rdma:hostname domain qemu+ssh://hostname/system s/x-rdma/rdma/ and I believe we should use rdma://hostname as the URI > Full documenation of the feature: http://wiki.qemu.org/Features/RDMALiveMigration

> @@ -2561,6 +2570,10 @@ virQEMUCapsInitQMPMonitor(virQEMUCapsPtr qemuCaps, > if (qemuCaps->version >= 1006000) > virQEMUCapsSet(qemuCaps, QEMU_CAPS_DEVICE_VIDEO_PRIMARY); > > + if (qemuCaps->version >= 2000000) > + virQEMUCapsSet(qemuCaps, QEMU_CAPS_MIGRATE_QEMU_RDMA); > + > + And here we need a better check for rdma migration. What if someone compiles QEMU without RDMA support?