Re: [libvirt] [PATCH RFCv2 0/4] Add optional pSeries features

On Tue, Feb 06, 2018 at 17:54:55 +0100, Andrea Bolognani wrote: I wanted to moan about missing docs and sub-par commit messages but okay. Note that without documentation it's not possible to scrunitize whether it makes any particular sense to expose a given feature at all. Since probing is not implemented I don't think it makes sense to introduce cabapility bits for every single feature since they are grouped under the same version check. Even if qemu adds QMP probing of these the capability check will not go away since it would create a regression in behaviour. This means that you can remove all the capability bits and group all of them under a single one since they will only ever be enabled using that version check. Also I really don't think that every single feature should have it's own XML document to test it. You can gradually add them to a single one and test that all are added.