Re: [libvirt] [PATCH 02/14] qemuDomainDiskChangeSupported: Deny changing reservations

On Mon, 2018-02-12 at 16:40 +0100, Peter Krempa wrote: > > @@ -6865,6 +6865,14 @@ qemuDomainDiskChangeSupported(virDomainDiskDefPtr disk, > > CHECK_EQ(src->readonly, "readonly", true); > > CHECK_EQ(src->shared, "shared", true); > > > > + if (!virStoragePRDefIsEqual(disk->src->pr, > > + orig_disk->src->pr)) { > > + virReportError(VIR_ERR_OPERATION_UNSUPPORTED, > > + _("cannot modify field '%s' of the disk"), > > + "reservations"); > > Is there a particular reason to format 'reservations' separately? > > Translations should not translate it, but doing this is generally deemed > translation unfriendly. Wouldn't that actually be better for translators? Assuming there's going to be more than a single field, you can translate the message once and it will work for all instances. Of course that only works if, like in this case, the variable part itself does not need translation.