Re: [libvirt] [PATCH v2 1/3] conf: don't use "class" as name in _virNodeDevCapPCIDev

Vim treats *.h files as cpp ones with respect to syntax highlighting.

Thus "class" in _virNodeDevCapPCIDev highlighted mistakenly. This can be fixed by filetype detection code tunables but it is more convinient to skip this tuning by every project member. Let's just use "klass" as field name instead of _class or class and add syntax rule.

Signed-off-by: Nikolay Shirokovskiy <nshirokovskiy(a)virtuozzo.com&gt; --- cfg.mk | 8 ++++++++ src/conf/node_device_conf.c | 4 ++-- src/conf/node_device_conf.h | 4 ++-- src/node_device/node_device_udev.c | 4 ++-- 4 files changed, 14 insertions(+), 6 deletions(-) diff --git a/cfg.mk b/cfg.mk index f99b8ae631..88198037cc 100644 --- a/cfg.mk +++ b/cfg.mk @@ -1075,6 +1075,14 @@ sc_require_attribute_cleanup_initialization: halt='variable declared with a cleanup macro must be initialized' \ $(_sc_search_regexp) +# "class" in headers is not good because by default Vim treats it as a keyword +sc_prohibit_class_in_headers: + @prohibit=' +_?class *;' \ + in_vc_files='\.h$$' \

+ halt='use klass instead of class or _class as name in header files' \ + $(_sc_search_regexp) + + # We don't use this feature of maint.mk. prev_version_file = /dev/null