Re: [libvirt] [PATCH v3 24/34] Adapt to VIR_STRDUP and VIR_STRNDUP in src/uml/*
On 05/03/2013 08:53 AM, Michal Privoznik wrote:
---
src/uml/uml_conf.c | 10 ++++------
src/uml/uml_driver.c | 8 +++-----
2 files changed, 7 insertions(+), 11 deletions(-)
/me needs to go to bed before my eyes glaze over...
+++ b/src/uml/uml_driver.c
@@ -491,7 +490,7 @@ umlStateInitialize(bool privileged,
"%s/log/libvirt/uml", LOCALSTATEDIR) == -1)
goto out_of_memory;
- if ((base = strdup(SYSCONFDIR "/libvirt")) == NULL)
+ if (VIR_STRDUP_QUIET(base, SYSCONFDIR "/libvirt") < 0)
Why VIR_STRDUP_QUIET here? Ah, this function was using VIR_ERROR
instead of normal virReportOOMError(). I think this is another case
where changing from quiet->noisy is probably better.
ACK.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
Attachments:
- signature.asc (application/pgp-signature — 621 bytes)