On 12/17/2015 09:54 PM, John Ferlan wrote:
ping?
Looks good to me. Didn't think you needed a reply from me. But yes, I
forgot this part. Only went for the API since that was what I needed in
CloudStack.
Thanks -
John
On 12/02/2015 06:18 PM, John Ferlan wrote:
> Commit id '3c7590e0' added the ability to delete snapshots for rbd backends,
> but did not provide the virsh commands in order to handle that option.
>
> The first two patches fix a couple of minor nits - not using virCheckFlags
> in virStorageBackendRBDDeleteVol even though the flags are used. Also,
> the virStorageVolDeleteFlags did not document the possible flags. Added
> the reference for the API.
>
> The third patch is the meat where the --delete-snapshots flag to virsh
> commands 'undefine' and 'vol-delete' was added and handled.
>
> cc'd author of '3c7590e0' - hopefully this series could be applied and
> tested in a "real" environment.
>
> John Ferlan (3):
> storage: Add virCheckFlags to virStorageBackendRBDDeleteVol
> libvirt: Add virStorageVolDeleteFlags to virStorageVolDelete
> virsh: Add --delete-snapshots flag for undefine and vol-delete
>
> src/libvirt-storage.c | 2 +-
> src/storage/storage_backend_rbd.c | 3 +++
> tools/virsh-domain.c | 14 +++++++++++++-
> tools/virsh-volume.c | 12 +++++++++++-
> tools/virsh.pod | 14 +++++++++++++-
> 5 files changed, 41 insertions(+), 4 deletions(-)
>