Re: [PATCH v3 1/3] test_driver: Implement virDomainGetMessages

On Fri, 2021-07-09 at 15:10 +0200, Martin Kletzander wrote: > On Wed, Jun 30, 2021 at 10:53:44AM +0800, Luke Yue wrote: > > Signed-off-by: Luke Yue <lukedyue(a)gmail.com&gt; > > --- > > src/test/test_driver.c | 53 > > ++++++++++++++++++++++++++++++++++++++++++ > > 1 file changed, 53 insertions(+) > > > > If you first abstract the code from qemu driver then there's less > code > move to add this functionality.  Also one more thing to check is > whether > qemu driver is the only one that has this code and that it is not > duplicated anywhere else - we could dedup even more code ;) Thanks! But I'm sorry that I find out that qemu driver seems to be the only one that has this code (what I extracted to virDomainObjGetMessages), do I miss something? Or it's just a general suggestion for future development work?