On Fri, Nov 15, 2013 at 01:18:08PM +0100, Jiri Denemark wrote:
On Fri, Nov 15, 2013 at 20:47:43 +0900, Michael Avdienko wrote:
QEMU 1.6.0 introduced new migration status: setup Libvirt does not expect such string in QMP and refuses to migrate with error "unexpected migration status in setup"
This patch fixes it.
Sorry for previous bad try. Unfortunately I have seen Serge Hallyn's patch too late. Now I think it's better to include following code into my patch: if (setting_up) { priv->job.info.fileTotal = -1; priv->job.info.fileRemaining = -1; priv->job.info.fileProcessed = 0;
priv->job.info.memTotal = -1; priv->job.info.memRemaining = -1; priv->job.info.memProcessed = 0;
priv->job.info.dataTotal = -1; priv->job.info.dataRemaining = -1; priv->job.info.dataProcessed = 0; } But I'm not sure if my patch is good enough. If it is then I will include aforementioned code in it.
I don't think this is needed at all, I'd just keep them all 0.
This patch gets my ACK as is but I won't it push yet in case someone provides a good reasoning for initializing the counters to 2^64-1.
I don't see a good reason to initialize it to -1. IMHO 0 is more appropriate Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|