Re: [libvirt] [PATCH] qemuDomainUpdateDeviceConfig: Allow startupPolicy update, yet again
On 14.09.2015 13:24, Peter Krempa wrote:
On Mon, Sep 14, 2015 at 13:02:49 +0200, Michal Privoznik wrote:
> https://bugzilla.redhat.com/show_bug.cgi?id=1159219
>
> So, in 11e058ca589808bd I've tried to make UpdateDevice update
> startupPolicy too. And it worked well until somebody came around
> and pushed d0dc6c036914da which accidentally removed my
> contribution. Redo my commit.
>
> Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com>
> ---
> src/qemu/qemu_driver.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
> index 91eb661..03ef972 100644
> --- a/src/qemu/qemu_driver.c
> +++ b/src/qemu/qemu_driver.c
> @@ -8353,6 +8353,7 @@ qemuDomainUpdateDeviceConfig(virQEMUCapsPtr qemuCaps,
> * We allow updating src/type//driverType/cachemode/
> */
> orig->cachemode = disk->cachemode;
> + orig->startupPolicy = disk->startupPolicy;
This also might make sense to be updated in the "live" case to
"requisite" setting for migration.
I think not only that. In fact all three options make sense on live case
too. mandatory - I want to fail migration if disk is not present on dst,
requisite is the same as optional in this case, since if domain is
started up, it means that disk is there, it's present. But I might want
to drop it during migration.
Okay, I'll repost.
Michal