Re: [libvirt] [PATCHv2 4/3] snapshot: make offline qemu snapshots atomic

On 03/19/2012 07:40 AM, Peter Krempa wrote: > On 03/17/2012 05:33 PM, Eric Blake wrote: >> Offline internal snapshots can be rolled back with just a little >> bit of refactoring, meaning that we are now automatically atomic. >> >> * src/qemu/qemu_domain.c (qemuDomainSnapshotForEachQcow2): Move >> guts... >> (qemuDomainSnapshotForEachQcow2Raw): ...to new helper, to allow >> rollbacks. >> * src/qemu/qemu_driver.c (qemuDomainSnapshotCreateXML): Offline >> snapshots are now atomic. >> ---

> > Otherwise looks good. ACK with that suggested change. Same story as for 3/3 - I'll wait to push this until I've run a few more tests for the rest of my pending series, in case I find any more last-minute issues.